> On Oct. 19, 2011, 3:59 p.m., Andrea Diamantini wrote: > > src/tabbar.h, line 107 > > <http://git.reviewboard.kde.org/r/102811/diff/4/?file=38482#file38482line107> > > > > This has to be "bool isValidUrl(const QString &url)" > > Andrea Diamantini wrote: > and obviously the implementation has to be fixed accordingly. After this, > everything seems ready for merge :) > > Furkan Üzümcü wrote: > But I edit "url" inside the function. Why has it to be that way? > > Andrea Diamantini wrote: > Just add a QString editedUrl variable to your code. You can probably read > everywhere on the net why value passing methods have to be avoided and what > are the occasions to use pointer passing ones.
Done. As usual I don't have any access. Can you please merge it? :( - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102811/#review7492 ----------------------------------------------------------- On Oct. 19, 2011, 5:12 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102811/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2011, 5:12 p.m.) > > > Review request for rekonq. > > > Description > ------- > > With this patch you can drop a URL(s) on the tabbar to open it in new tab(s) > or text to search it. > > > Diffs > ----- > > src/tabbar.h b4c816b > src/tabbar.cpp ea01ef9 > > Diff: http://git.reviewboard.kde.org/r/102811/diff/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
