> On Oct. 20, 2011, 8:11 p.m., Andrea Diamantini wrote: > > Excuse me, but... before merge... Can you explain me why you are not simply > > using QUrl::isValid() method?
QUrl::isValid() method doesn't really work as it should. Thiago Macieira explains the reason better in this blog post. --> http://www.macieira.org/blog/2011/10/qurl-in-qt-5-validity/ - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102811/#review7516 ----------------------------------------------------------- On Oct. 19, 2011, 5:12 p.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102811/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2011, 5:12 p.m.) > > > Review request for rekonq. > > > Description > ------- > > With this patch you can drop a URL(s) on the tabbar to open it in new tab(s) > or text to search it. > > > Diffs > ----- > > src/tabbar.h b4c816b > src/tabbar.cpp ea01ef9 > > Diff: http://git.reviewboard.kde.org/r/102811/diff/diff > > > Testing > ------- > > Compiles and works. > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
