----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103451/#review9669 -----------------------------------------------------------
Code seems ok now, but I tested your patch and I cannot really understand why we should apply such changes. Chromium and Firefox both show such actions in tabbar contextual menu, so I think you should spend some words to explain why you are suggesting such changes. - Andrea Diamantini On Jan. 7, 2012, 2:28 p.m., Yusuf TEZCAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103451/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2012, 2:28 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Removed the "Open The Last Closed Tab" and "Closed Tabs" actions and set > ""New Tab"" button's context menu to the empty area context menu on TabBar. > I am a GCI-Student who wrote this patch. > > > Diffs > ----- > > src/mainview.cpp 6285159 > src/tabbar.cpp 4834095 > > Diff: http://git.reviewboard.kde.org/r/103451/diff/diff > > > Testing > ------- > > > Thanks, > > Yusuf TEZCAN > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
