> On Jan. 9, 2012, 6:11 p.m., Andrea Diamantini wrote: > > Code seems ok now, but I tested your patch and I cannot really understand > > why we should apply such changes. Chromium and Firefox both show such > > actions in tabbar contextual menu, so I think you should spend some words > > to explain why you are suggesting such changes. > > Furkan Üzümcü wrote: > "Open Last Closed Tab" and "Closed Tabs" actions are in both empty are > context menu and tab context menu. User doesn't need it in both places just > one is enough. For Chromium, it doesn't have the same actions in both areas. > I think this takes up too much space and doesn't really seem good, imho. > Actually I just reconsidered the new tab context menu it's not really > needed. But, it's ok if we have it though. :) > > Andrea Diamantini wrote: > If we remove some actions from tabbar contextual menu and move them in > blank space, we need an option to launch them where blank space is "nothing" > (i.e. full tabbar), so new tab context menu is useful in this case. But this > seems to me just a way to complicate things. I'd really like to hear Yusuf's > reasons for such a change.
Right! Sorry I hadn't considered a full tab bar. :) You're right. - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103451/#review9669 ----------------------------------------------------------- On Jan. 7, 2012, 2:28 p.m., Yusuf TEZCAN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103451/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2012, 2:28 p.m.) > > > Review request for rekonq. > > > Description > ------- > > Removed the "Open The Last Closed Tab" and "Closed Tabs" actions and set > ""New Tab"" button's context menu to the empty area context menu on TabBar. > I am a GCI-Student who wrote this patch. > > > Diffs > ----- > > src/mainview.cpp 6285159 > src/tabbar.cpp 4834095 > > Diff: http://git.reviewboard.kde.org/r/103451/diff/diff > > > Testing > ------- > > > Thanks, > > Yusuf TEZCAN > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
