> On Jan. 9, 2012, 5:31 p.m., Andrea Diamantini wrote: > > I confirm the problem, reported also in bugzilla. But I tested your > > solution and I don't think this really fixes the issue. Real solution is > > changing again suggestions order and let search result being first. > > Andrea Diamantini wrote: > I committed a nice improvement to ordering that imho fixes also the > issue. Please test it. > > Furkan Üzümcü wrote: > It works. But sometimes crashes when I type the first letter and gives > this output --> http://paste.kde.org/184250/ > I can't really establish a baseline for this crash. It happens randomly. > > Furkan Üzümcü wrote: > Actually still it doesn't order right. User input still comes later.
My new patch based on yours works. - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103652/#review9665 ----------------------------------------------------------- On Jan. 10, 2012, 8:33 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103652/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2012, 8:33 a.m.) > > > Review request for rekonq. > > > Description > ------- > > Currently, when you type something in the URL bar the completetion widget > pops up and activates the first item. And you can't load the URL typed in > when you hit enter. Rekonq loads the actvated item. This patch fixes that > issue. When you reached the index zero if you go up again the last item gets > deactivated and you can load the typed string. > > > Diffs > ----- > > src/urlbar/urlresolver.cpp 5bf2ee6 > > Diff: http://git.reviewboard.kde.org/r/103652/diff/diff > > > Testing > ------- > > Compiles and works > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
