> On Jan. 10, 2012, 6:05 p.m., Andrea Diamantini wrote: > > To say the truth I prefer actual logic, where the "guessing part" is when > > user types, while when he clicks he just knows what url will be loaded. > > Furkan Üzümcü wrote: > You still know wht will be loaded. The old way kind of restricts user. He > has to press down a few times to load the URL he/she wants. Just try it for > yourself. This really annoys me. > > Andrea Diamantini wrote: > Sorry, I don't understand. This is what user sees typing "kde.org": > http://wstaw.org/m/2012/01/12/kde_org_actual.png , while this is what he sees > with your patch: http://wstaw.org/m/2012/01/12/kde_org_furkan.png . Who has > to move to find the URL he/she wants? I guess the second one. Please consider > that just typing "k" and until the thing you write IS an url, you see > relevant urls before: http://wstaw.org/m/2012/01/12/k_actual.png . > As said, in the actual version the "guessing" part works while user > types, with this patch user press enter and yet does not know what url will > be loaded. So, I yet vote for actual code. Please, present a meaningful use > case to show why your patch is better than actual behavior.
Now I feel bad. :( Somehow, your patch crashed as I mentioned earlier that's why I made this patch (Actually the difference I remove the user input URL part). But It doesn't crash now. I haven't checked it after the first time because I was using my patch. Sorry for the noise Andrea. I LOVE the current way. - Furkan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103652/#review9715 ----------------------------------------------------------- On Jan. 10, 2012, 10:27 a.m., Furkan Üzümcü wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103652/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2012, 10:27 a.m.) > > > Review request for rekonq. > > > Description > ------- > > Currently, when you type something in the URL bar the completetion widget > pops up and activates the first item. And you can't load the URL typed in > when you hit enter. Rekonq loads the actvated item. This patch fixes that > issue. When you reached the index zero if you go up again the last item gets > deactivated and you can load the typed string. > > > Diffs > ----- > > src/urlbar/completionwidget.h 517a7ea > src/urlbar/completionwidget.cpp b349041 > src/urlbar/urlbar.h 2d158ff > src/urlbar/urlresolver.h 167ee28 > src/urlbar/urlresolver.cpp 5bf2ee6 > > Diff: http://git.reviewboard.kde.org/r/103652/diff/diff > > > Testing > ------- > > Compiles and works > > > Thanks, > > Furkan Üzümcü > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
