> On Feb. 7, 2012, 8:40 a.m., Andrea Diamantini wrote: > > This is obviously 0.10 material, isn't it?
It seems I'm a bit distract this morning, sorry. Taking a look to the patch. Thanks for it. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103880/#review10385 ----------------------------------------------------------- On Feb. 6, 2012, 11:03 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103880/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2012, 11:03 p.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > this patch would add advanced printing options, like having several pages on > one sheet but remove the print preview. > i've found no solution of having both, because the advanced options are added > through kde printing system and QPrintPreviewDialog has no option to add > those advance dialogs. furthermore there would be kde's own print-preview, > but this one is very limited and you can't even print directly from it. > so what to do? > i just did this patch because a user on irc was complaining that he can't > print several pages on one sheet. > the decision on whether to include this is up to you. > > > Diffs > ----- > > src/mainwindow.cpp 97f4d94 > > Diff: http://git.reviewboard.kde.org/r/103880/diff/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes Tröscher > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
