> On Feb. 7, 2012, 8:40 a.m., Andrea Diamantini wrote: > > This is obviously 0.10 material, isn't it? > > Andrea Diamantini wrote: > It seems I'm a bit distract this morning, sorry. Taking a look to the > patch. Thanks for it.
I took a look at the patch and to Chrome/Firefox/Konqueror behavior. Chrome/Konqueror works in the same way you implemented here, while Firefox proposes a "print" menu, showing more options (print, print preview, page setup). On the other hand, the print preview option was requested in the early rekonq days and was something I am really used, too. I think that 90% of users when press print wanna just check a first preview and then press ok/cancel. So, I would NOT completely remove the print preview. IMHO we have two choices here: 1) add a menu (like firefox) leaving the actual print action as default (the CTRL+P triggered) and providing a "print setup" option as you implemented 2) implement a new dialog, showing preview and a button to select KDE print option. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103880/#review10385 ----------------------------------------------------------- On Feb. 6, 2012, 11:03 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103880/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2012, 11:03 p.m.) > > > Review request for rekonq and Andrea Diamantini. > > > Description > ------- > > this patch would add advanced printing options, like having several pages on > one sheet but remove the print preview. > i've found no solution of having both, because the advanced options are added > through kde printing system and QPrintPreviewDialog has no option to add > those advance dialogs. furthermore there would be kde's own print-preview, > but this one is very limited and you can't even print directly from it. > so what to do? > i just did this patch because a user on irc was complaining that he can't > print several pages on one sheet. > the decision on whether to include this is up to you. > > > Diffs > ----- > > src/mainwindow.cpp 97f4d94 > > Diff: http://git.reviewboard.kde.org/r/103880/diff/diff > > > Testing > ------- > > compiles and works > > > Thanks, > > Johannes Tröscher > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
