> On Aug. 28, 2011, 3:23 p.m., Andrea Diamantini wrote: > > It is really improved from the first version tried :) > > Anyway, I think its behavior has to modified. In fact Firefox/Chrom* don't > > have a loading animation on their urlbar, so I really think this feature > > should work just on loadFinished (and probably also moved there). I mean > > that during page load, everything should be normal and "coloring" activated > > just on loadFinished. > > Johannes Tröscher wrote: > should be just an easy check on progr. i'll post an updated version
Why would it be so important that the coloring only comes into place on loadFinished? Don't see where it would conflict, and finally it's a security related feature, so we want the user to be informed as soon as possible of the actual domain they landed on. Possibly the gray should be quite a bit darker to improve readability, not only but especially in private mode. Also, now that the urlbar doesn't turn greenish anymore, the "https:" protocol should turn green the way it does in Chromium. But then the coloring IMHO should be fine enough for now. @Johannes: Are you still ready to post an updated version, or should somebody continue working on it? - Bernd Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102402/#review6099 ----------------------------------------------------------- On Aug. 27, 2011, 5:24 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102402/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2011, 5:24 p.m.) > > > Review request for rekonq. > > > Description > ------- > > highlight host in urlbar like in firefox. > this patch isn't finished yet. > this code also evaluates the actual textrect including all margins, so the > "empty-progress==0" message will be drawn in the "real" center. > > > Diffs > ----- > > src/urlbar/urlbar.cpp 04d9698 > > Diff: http://git.reviewboard.kde.org/r/102402/diff/ > > > Testing > ------- > > compiles and works. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/102402/s/238/ > > http://git.reviewboard.kde.org/r/102402/s/239/ > > > Thanks, > > Johannes Tröscher > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
