> On Aug. 23, 2011, 10:37 a.m., Johannes Tröscher wrote: > > src/urlbar/urlbar.cpp, line 172 > > <http://git.reviewboard.kde.org/r/102402/diff/3/?file=32520#file32520line172> > > > > have a look at line 170. i just thought it's better not to hardcode it.
I know it's hardcoded (Me and Lionel wrote it). We did it that way to get sure we use a gray background for the private mode in every style as there were happening some "strange" combinations for it in some styles. We can also remove it as Chromium/Firefox did, just showing the private icon, it will be probably the easiest solution. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102402/#review5938 ----------------------------------------------------------- On Aug. 22, 2011, 11:18 a.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102402/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2011, 11:18 a.m.) > > > Review request for rekonq. > > > Summary > ------- > > highlight host in urlbar like in firefox. > this patch isn't finished yet. > this code also evaluates the actual textrect including all margins, so the > "empty-progress==0" message will be drawn in the "real" center. > > > Diffs > ----- > > src/urlbar/urlbar.cpp 17ba4bb > > Diff: http://git.reviewboard.kde.org/r/102402/diff > > > Testing > ------- > > compiles and works. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/102402/s/238/ > > http://git.reviewboard.kde.org/r/102402/s/239/ > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
