> On July 29, 2013, 8:30 a.m., Andrea Diamantini wrote: > > not sure way, I cannot see your patch. Impossible to review this.
Sorry, when I try reuploading it the same thing happens :(. Maybe a bug in reviewboard? It's very small/simple though: http://pastebin.com/FHqk22Hs - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111610/#review36710 ----------------------------------------------------------- On July 19, 2013, 9:55 p.m., Diego Soenens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111610/ > ----------------------------------------------------------- > > (Updated July 19, 2013, 9:55 p.m.) > > > Review request for rekonq. > > > Description > ------- > > If the mouse moves even 1 pixel while the middle mouse button is being > pressed/clicked to close a tab it causes KTabBar to not emit > mouseMiddleClick() if isMovable() == true. > As a result the tab doesn't get closed and the user has to try again and this > can happen a few times in a row if the mouse has a "hard" middle mouse > button. Quite annoying :(. > > See: > http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/ktabbar_8cpp_source.html#l00209 > According to the comment it's a "compatibility feature for old middle mouse > tab moving" so I'm not exactly sure if this should even be fixed to begin > with and whether Rekonq is the place to do it in this case. > > Edit: not sure why my diff isn't working? > > > Diffs > ----- > > src/tabwindow/tabbar.cpp eb062bf > > Diff: http://git.reviewboard.kde.org/r/111610/diff/ > > > Testing > ------- > > Been running this patch for a few hours. Everything seems to work as intended. > > > Thanks, > > Diego Soenens > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
