Cheers! This is much better. However there is still a small issue.
Because you are using the triple quote notation, you should then not
escape your " characters as \". This is only needed in the single
quote strings. The output file will then contain \ characters. I
suggest switching to the notation as in the
lib/software/opendx/files.py file whereby each line is written to the
script with a separate file.write("text...\n") call. So then the
first few lines would look something like:
# Write the script to file.
file.write("#!/usr/bin/env python\n")
file.write("\n")
file.write("import glob, os, sys\n")
file.write("import shlex,subprocess\n")
file.write("import argparse\n")
file.write("from itertools import chain\n")
A line with quotes would then look like:
file.write("gracefiles = glob.glob(\"*.agr\")\n")
Also, two additional tiny things. The function should shift to the
top to be alphabetically sorted - useful if for developers who do not
use an integrated development environment (IDE) like myself. And one
of the comments in the script talks about *.agt files.
Cheers,
Edward
On 18 June 2013 14:21, Troels E. Linnet
<[email protected]> wrote:
> Follow-up Comment #2, bug #20916 (project relax):
>
> Improvement according to suggestions
> (http://article.gmane.org/gmane.science.nmr.relax.devel/3964)
>
> patchV2 attached
>
> (file #18111)
> _______________________________________________________
>
> Additional Item Attachment:
>
> File name: patchV2 Size:5 KB
>
>
> _______________________________________________________
>
> Reply to this item at:
>
> <http://gna.org/bugs/?20916>
>
> _______________________________________________
> Message sent via/by Gna!
> http://gna.org/
>
>
> _______________________________________________
> relax (http://www.nmr-relax.com)
>
> This is the relax-devel mailing list
> [email protected]
>
> To unsubscribe from this list, get a password
> reminder, or change your subscription options,
> visit the list information page at
> https://mail.gna.org/listinfo/relax-devel
_______________________________________________
relax (http://www.nmr-relax.com)
This is the relax-devel mailing list
[email protected]
To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel
