Ian Wadham <[email protected]> writes: > On Tuesday 17 May 2011 12:26:16 am Benjamin Reed wrote: >> On 5/16/11 7:36 AM, Ian Wadham wrote: >> > Time is running on, so I have decided to go ahead with the hard >> > dependency of KGoldrunner on OpenAL and SndFile after all. I have >> > committed a change whereby KGoldrunner can not compile and build if >> > OpenAL and SndFile are missing, together with improved macro_log_feature >> > messages for packagers and distros. I expect, however, that OpenAL and >> > SndFile will be found to be widely available across platforms. >> > >> > I guess a deciding factor for me was that games are good ambassadors for >> > KDE (even Gnome users play them) and I wanted KGoldrunner to be sounding >> > its best in this release. >> >> Just to confirm, "hard dependency" means that kgoldrunner just won't be >> built if they don't exist, right? Not that kdegames will fail to >> configure... =) >> > Urk! It appears that if you declare a REQUIRED package in a subdirectory it > gets propagated up to the top level and, if the package is missing, the whole > module fails at the CMake configuration stage, i.e. bye bye KDE Games. > If the package is declared as optional, then compilation can fail in the > subdirectory and the build of KDE Games comes to a grinding halt mid way.
FWIW, I ended up posting a reply to this to kde-commits and kde-buildsystem [1]. [1] http://lists.kde.org/?l=kde-buildsystem&m=130568651001795&w=2 _______________________________________________ release-team mailing list [email protected] https://mail.kde.org/mailman/listinfo/release-team
