-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105721/
-----------------------------------------------------------
(Updated July 25, 2012, 2:30 p.m.)
Review request for kwin, Release Team and Martin Gräßlin.
Changes
-------
adding release team for breaking the tagging freeze
Description
-------
it is mandatory to manage loadPlugin() and destroyPreviousPlugin() using
disablePreview()
loadPlugin() moves the present factory pointer to "old_fact" which is then
deleted by the succeeding destroyPreviousPlugin()
I also left a warning into the sources for our heirs ;-)
This addresses bug 304026.
http://bugs.kde.org/show_bug.cgi?id=304026
Diffs
-----
kwin/kcmkwin/kwindecoration/decorationmodel.cpp 3d3bb86
kwin/kcmkwin/kwindecoration/preview.h 20ee869
kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
Diff: http://git.reviewboard.kde.org/r/105721/diff/
Testing
-------
Yes, quite some.
I'm pretty sure this is it and that a sanitation on recreate is not necessary
for commented reasons.
The actual troublemaker was the BorderSizesRole implementation
/me wonders whether we can now also shortcut if (lib->loaded()) - gonna try
that tonight.
I *may* be not be back in time (but i doubt so), so iff i've not acted on call
until 22:00 CEST just push this and the other one or two reviews in a row
before the freeze on my behalf. Thanks.
Thanks,
Thomas Lübking
_______________________________________________
release-team mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/release-team
