Yeah, let's get it into 5.0.1 if possible. The patch is very safe, I can't see how including it could cause issues in the release process.
Cheers, Lars On Jan 29, 2013, at 10:24 AM, Sergio Ahumada <[email protected]> wrote: > On 01/29/2013 09:18 AM, Stephen Kelly wrote: >> >> Hi there, >> >> A commit to Qt 4.8 was lost as it missed the branching of Qt 5. >> >> https://codereview.qt-project.org/#change,46060 >> >> The Qt 4 commit is here: >> >> https://qt.gitorious.org/qt/qt/commit/0f6853e9c775dd8fbb64f66119c2c9b2ea23da29 >> >> Very important note: The remark that the commit should be removed in Qt 5 was >> added by Gabriel, not by me. I don't know why he added that remark. It was >> not >> what I submitted: http://qt.gitorious.org/qt/qt/merge_requests/694 >> >> Thiago suggested adding that commit to Qt 5.0.1, but I'll let him add the >> reason for that. >> >> Thanks, > > Hi, > > In my personal opinion you should push the stuff to 'refs/for/release' > with the arguments .. a note in the changes file .. get it reviewed (add > Lars) .. and let's see if it can make it .. > > Cheers. > -- > Sergio Ahumada > Release Engineer - Digia, Qt > _______________________________________________ > Releasing mailing list > [email protected] > http://lists.qt-project.org/mailman/listinfo/releasing _______________________________________________ Releasing mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/releasing
