Il 03 marzo 2019 17:36:07 CET, Denis 'GNUtoo' Carikli
<[email protected]> ha scritto:
>
>> This removes some hex-encoded binary-only files
>> that have no license at all, thus being nonfree.
>In that case the licenses is the GPLv2.
Oh, good to know! Is it because they're included in the Linux tree?
>Are the files data or code?
Well, from what read in the comments inside the drivers code, it seems like it
could be configuration testing data, that is produced through cypress
configuration utility software.. but I can't be sure.
>
>If they are code, what do you think of something like that:
>
>> [PATCH] cypress: Remove unused firmwares
>
>> The firmwares being removed consist of executable code
>> which are being shipped as hexadecimal arrays inside the
>> Linux source code.
>>
>> While the firmwares are GPLv2 as per Linux license, they
>> lack corresponding source code.
>>
>> Theses firmwares are proabaly meant for testing the touch keys during
>> the production of the device.
>> They are not needed during normal operation.
>>
>> This patch does NOT solve other potential licensing related issues
>> with the other source files in the cypress directory.
>
>If they are only data or if we don't know what they are it would be
>best to mention it in the commit message too.
Yes, I like your version of the commit message. And yes, I'd include the fact
that we're not sure about what the hex data is.
Thanks for the review!
Fil
--
Sent from my libre Replicant phone.
www.replicant.us
_______________________________________________
Replicant mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/replicant
