Hi,
I really don't have expertise on this so if you think it is fine I'm
okay if you push it since nobody has reviewed this in such a long time.
One thing caught my eye but it could be just okay:
Denis 'GNUtoo' Carikli:
> @@ -1449,8 +1449,9 @@ RIL_RadioFunctions ril_radio_functions = {
> ril_get_version
> };
>
> -const RIL_RadioFunctions *RIL_Init(const struct RIL_Env *env, int argc,
> - char **argv)
> +const RIL_RadioFunctions *RIL_Init(const struct RIL_Env *env,
> + __attribute__((unused)) int argc,
> + __attribute__((unused)) char **argv)
> {
> RIL_RadioFunctions *radio_functions;
> pthread_attr_t attr;
Why is the env variable here not marked unused meanwhile the two others are?
Joonas
_______________________________________________
Replicant mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/replicant
