Thanks a lot for preparing the patch Denis. It is missing one important thing though. Please set "ro.libagl=0" in vendor/replicant/config/common.mk line 242. Like this:
- # use Android's software renderer by default - PRODUCT_PROPERTY_OVERRIDES += ro.libagl=1 + # This makes sure that Mesa (llvmpipe) is used as the default renderer + PRODUCT_PROPERTY_OVERRIDES += ro.libagl=0 Unto how the patch works. Setting ro.libagl=0 has above makes sure that frameworks/native/tree/opengl/libs/EGL/Loader.cpp selects /system/lib/egl/libGLES_mesa.so (llvmpipe) as the default renderer (behaviour is on the class "MatchFile"). This default renderer can then be overwritten on a per-app basis by placing empty files in specific directories. That's what the previous Andrés' patches (that were merged) allow us to do. The specific directories and the workings of it are explained by Andrés in the first email of this patch series: https://lists.osuosl.org/pipermail/replicant/2019-August/002054.html Particularly, this patch places some files that make bootanimation, SurfaceFlinger and system_server use libagl instead of the default (llvmpipe). That's required because these 3 components are too slow with llvmpipe. Right now I am unable to produce a Replicant 6 build, but I have a spare i9300 where I can test. Could you please create a build including a fixed version of this patch (as per above) and upload it somewhere? I'll flash it and let you know if it is as fast as it should be. On 12/12/2019 23:01, Denis 'GNUtoo' Carikli wrote: > On Thu, 12 Dec 2019 02:35:34 +0000 > dllud <[email protected]> wrote: > >> Sorry, my bad, as Joonas correctly reviewed, the last patch shouldn't >> be merged. >> Instead, "ro.libagl=0" should be set in >> vendor/replicant/config/common.mk in order to have llvmpipe as >> default. > Thanks. During testing, I was wondering why it wasn't set, now I > get it. > >> Along with that we need the two commits from adjtm that I >> mentioned previously, otherwise the system will be too slow. > I've prepared a patch with that but while it may look good it's nowhere > ready: > - I need the permission to add signed-off-by from Andrés Domínguez > - The commit message reflects what it's supposed to do but I've no idea > how it's supposed to work. All I see is that it copies some empty > files in some specific locations. > - As I don't understand how it works, I don't understand either how to > test it. > > As I've added the llvmpipe.sh and androidsw.sh scripts to the image, I > just had to run llvmpipe.sh to enable llvmpipe. Once that was done, I > found the "desktop/launcher" way slower than with ro.libagl=1. > > Beside that I'm not sure how fast it's supposed to be. > > Denis. >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
