Hi Denis, these fixes to make the code easy to read is a good thing from my point of view.
There are two ways for break lines (Knuth and Python PEP8) and the PEP8 one could be more readable (see https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator). Do we have choosen one or does it depends on who wrote the code? (It would probably be a good thing to choose one) For example, following PEP8 rules, in @@ -134,8 +136,9 @@ int crespo_fmt_send(struct ipc_client *client, struct ipc_message *message) it should be written : - if (client == NULL || client->handlers == NULL || client->handlers->write == NULL || message == NULL) - return -1; + if (client == NULL || client->handlers == NULL + || client->handlers->write == NULL || message == NULL) + return -1; - Fil Lupin. _______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
