On Thu, 06 Feb 2020 23:43:14 +0000 Fil Lupin <[email protected]> wrote:
> Hi Denis, Hi, > these fixes to make the code easy to read is a good thing from my > point of view. Thanks a lot for the review. Given the amount of code (and my lack of sleep) it's really needed and appreciated. > There are two ways for break lines (Knuth and Python PEP8) and the > PEP8 one could be more readable (see > https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator). > Do we have choosen one or does it depends on who wrote the code? (It > would probably be a good thing to choose one) For the conventions, I tried to respect the ones that were in use already in the code, but I don't know if they refer to a specific code style that has a name. As for the line break I used the same conventions than in the Linux kernel and many other projects written in C. The argument for changing the linebreaks in python are very interesting, I'll try to do that in python. Though given that many people are already used to the former way to do it in C, I think it's best to keep it that way for C code. If I was starting libsamsung-ipc from scratch, I would have followed the kernel conventions completely, to be able to leverage their scripts that check the code style, but the diff would probably be too big, as we'd need to convert it from 4 spaces to tabs. The best way to go would probably be to find the code style that is the closest from the one that is already in use, and in a second time, to find or adapt tools to check that. Denis.
pgpMh5d2v9t2A.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
