On Sat, 21 Nov 2020 14:26:36 +0200 belgin <[email protected]> wrote:
Thanks a lot for the patch. So far I've found 2 small issues that needs to be fixed: - The patch lacks a signed-off-by. As you most probably know, this can be added with 'git commit --amend -s'. Doing that indicates that you certify that you either wrote the patch (which seems to be the case here) or otherwise have the right to pass it on as an free software patch. The certificate of Origin is available in Documentation/process/submitting-patches.rst in the Linux source code[1] In Replicant and libsamsung-ipc we require it because some upstream project like Linux strictly require it, so if we ever need to upstream patches (or even code derivated from libsamsung-ipc) it's better to have it. - The patch doesn't apply for me: in claws-mails I used save-as to save the email and I imported it with git am as usual: > $ git am ~/\[Replicant\]\ \[PATCH\]\ libsamsung-ipc\:\ improve\ board\ drivers\ print\ \(issue\ #2150\) > Applying: libsamsung-ipc: improve board drivers print (issue #2150) > error: patch failed: samsung-ipc/devices/galaxys2/galaxys2.c:74 > error: samsung-ipc/devices/galaxys2/galaxys2.c: patch does not apply > error: patch failed: samsung-ipc/devices/i9300/i9300.c:75 > error: samsung-ipc/devices/i9300/i9300.c: patch does not apply > error: patch failed: samsung-ipc/devices/n5100/n5100.c:76 > error: samsung-ipc/devices/n5100/n5100.c: patch does not apply > error: patch failed: samsung-ipc/devices/n7100/n7100.c:81 > error: samsung-ipc/devices/n7100/n7100.c: patch does not apply > Patch failed at 0001 libsamsung-ipc: improve board drivers print (issue #2150) > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". I've tried with master which gives me that commit here: > 139170c nv_data-imei: indicate that write-imei may or may not work I've also tried to apply it on top of replicant-6.0-0004-rc3 but it didn't work either. On top of which revision do you have it? Since sometimes git can manage to rebase patches applied at the right revision while it fails with git am, it might work too if I do that. I'll check the patch content once I manage to apply it as it seems way easier for me to check it once it has been applied. Thanks again for the patch. References: ----------- [1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.9.9#n422 Denis.
pgpEcy5ludJO6.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
