On Sun, 22 Nov 2020 07:43:17 +0200 Belgin Stirbu <[email protected]> wrote:
> Subject: [Replicant] [PATCH v2] libsamsung-ipc: improve board drivers Thanks. I've now reviewed the patch and beside some whitespace issues to fix, everything looks good. As for the whitespaces, as we use the Linux coding style, so some of the spaces you introduced need to be convert to tabs. The checkpatch.pl script included in libsamsung-ipc can find errors like that: > $ ./scripts/checkpatch.pl \ > 0001-libsamsung-ipc-improve-board-drivers-print-issue-215.patch Here it detected that some spaces needs to be replaced with tabs: > WARNING: Statements should start on a tabstop > #411: FILE: samsung-ipc/devices/n7100/n7100.c:229: > + goto error; In addition there are some extra lines added that could be removed. For instance we have: > ipc_client_log(client, "Waiting for host wake failed"); > > + > rc = xmm626_kernel_smdk4412_link_control_enable(client, > modem_link_fd, Besides that everything looks good. So assumed that the above is fixed: Acked-by: Denis 'GNUtoo' Carikli <[email protected]> Denis.
pgpvTE9hcJ7_d.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/replicant
