Source: gnurobbo
Version: 0.68+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that gnurobbo could not be built reproducibly.
The list of source file is unsorted, which leads to a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..bbd7582
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort source files for deterministic linking order
+
+--- a/Makefile
++++ b/Makefile
+@@ -46,7 +46,7 @@
+ 
+ # You won't need to alter these
+ TARGET=$(shell cat TARGET)
+-SOURCES=$(wildcard *.c)
++SOURCES=$(sort $(wildcard *.c))
+ OBJECTS=$(patsubst %.c, %.o, $(SOURCES))
+ VERSION=$(shell cat VERSION)
+ 
diff --git a/debian/patches/series b/debian/patches/series
index fc50065..8fe44ce 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 format-security.patch
 Makefile.diff
+reproducible-build.patch

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to