Source: libpdl-io-hdf5-perl
Version: 1:0.73-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that libpdl-io-hdf5-perl could not be built reproducibly.
It iterates over a hash producing output in an unsorted order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..0534f55
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort hash keys while printing RETVALs
+
+--- a/hdf5.pd
++++ b/hdf5.pd
+@@ -1201,7 +1201,7 @@
+     $xsout .= ");\n";
+     $xsout .= "OUTPUT:\n";
+     $xsout .= "\tRETVAL\n";
+-    foreach $var (keys %output) {
++    foreach $var (sort keys %output) {
+       $xsout .= "\t$var\n";
+     }
+     $xsout .= "\n\n";
diff --git a/debian/patches/series b/debian/patches/series
index 38d06a4..d08672f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 remove-interpreter-from-package.patch
 clean_newFile_hd5.patch
 support-hdf5-1.8.13.patch
+reproducible_build.patch

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to