Source: libpdl-netcdf-perl
Version: 4.20-4
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that libpdl-netcdf-perl could not be built reproducibly.
While producing output it iterates over a hash in an unsorted order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..cb2d165
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,14 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Sort RETVAL keys for reproducible build
+
+--- a/netcdf.pd
++++ b/netcdf.pd
+@@ -822,7 +822,7 @@
+     $xsout .= ");\n";
+     $xsout .= "OUTPUT:\n";
+     $xsout .= "\tRETVAL\n";
+-    foreach $var (keys %output) {
++    foreach $var (sort keys %output) {
+       $xsout .= "\t$var\n";
+     }
+     $xsout .= "\n\n";
diff --git a/debian/patches/series b/debian/patches/series
index 44e398b..98b895b 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ perl-5.14-ccflags.patch
 spelling-errors.patch
 32bits-integer-size.patch
 skip-tests-for-big-endian.patch
+reproducible-build.patch

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to