Issue 646: postreview script diff command options "-urNp" do not work on  
Solaris.  gdiff required

New issue report by threebredagardens:
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
postrevew script

What steps will reproduce the problem?
1. Execute postreview on a Solaris system

The script will fail executing the diff command.

What is the expected output? What do you see instead?
Script does not work.

What operating system are you using? What browser?
Postreview -- command line.

Please provide any additional information below.

The diff command used in the postreview script to find the changes between
two versions of a file uses the command options "-urNp".  These options are
valid in GNU diff available on Linux, but not the diff command supplied by
default on Solaris.  Instead on Solaris gdiff should be used.

The following code change can work a round this problem:

ostype = execute ('uname -a')

if ostype == 'SunOS':
    diff_cmd = 'gdiff -urNp "%s" "%s"' % (old_file, new_file)
     diff_cmd = 'diff -urNp "%s" "%s"' % (old_file, new_file)

Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to