Issue 676: post-review fails when uploading diff

New issue report by lukatmyshu:
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
post-review command line tool

What steps will reproduce the problem?
1. Use the post-review tool to upload a diff for review

What is the expected output? What do you see instead?
The expected output is a new review should be posted.  Instead, I get an  
error stating
that the uploaded diff could not be uploaded.  Relevant output from -d

>>> HTTP POSTing to  
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail',  
u'err': {u'msg': u'One or more
fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.

What operating system are you using? What browser?
on linux, using svn version 1.5X

Please provide any additional information below.
  I looked at the diff generated by post-review vs. the one created w/ svn  
diff (works if I upload it
manually).  The output differed in the position of the newlines.   
Removing 'split-lines' from the
do_diff function fixed the problem for me.  (Also removed the  

Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to