Comment #4 on issue 676 by [email protected]: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676
This issue appears to be triggered by a very large diff request, and a mysql setting preventing the sql statement from being accepted. I'm using reviewboard 1.0rc2, Perforce (2007.2), MySQL 5.0. >>> Uploading diff, size: 1593200 >>> HTTP POSTing to >>> http://reviews.<snip>/api/json/reviewrequests/13/diff/new/: {} Error uploading diff: One or more fields had errors (105) >>> {u'fields': {u'path': [u'(1153, "Got a packet bigger than >>> \'max_allowed_packet\' bytes")']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} Your review request still exists, but the diff is not attached. Note the size of the diff: 1,593,200 bytes. Next, the max_allowed_packet setting in mysql: mysql> show variables like "max_allowed_packet"; +--------------------+---------+ | Variable_name | Value | +--------------------+---------+ | max_allowed_packet | 1048576 | +--------------------+---------+ 1 row in set (0.00 sec) The page at http://dev.mysql.com/doc/refman/5.0/en/packet-too-large.html says: "Both the client and the server have their own max_allowed_packet variable, so if you want to handle big packets, you must increase this variable both in the client and in the server." I'll try changing just the server side, but I don't know if this will be sufficient based on what the mysql link above says. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
