Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 813 by lukasz.jernas: Non C locale patches fail

Review board fails when trying to submint a patch created with diff in non
C locale.

Example patch:

--- DirtyDock.h (wersja 13191)
+++ DirtyDock.h (kopia robocza)
@@ -48,6 +48,9 @@
         QAction* centerZoomAction;

         std::vector<MapFeature*> Selection;
+       void changeEvent(QEvent*);
+       void retranslateUi();


What steps will reproduce the problem?
1. click New Review Request
2. Insert the above diff into a file a add it to the "Diff:" selector
3. click "Create Review Request"

What is the expected output? What do you see instead?
The patch should be sent and accepted and the usual stuff should follow,
instead I get back to r/new/ with and error "Unable to parse diff revision
header '(wersja 13191)'"

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to