Comment #3 on issue 813 by timw.at.work: Non C locale patches fail
http://code.google.com/p/reviewboard/issues/detail?id=813

It surprises me that a tool to generate data interchange files (svn diff)  
would
localize the internal diff markers (much like 'diff' doesn't consult the  
user's
preferred date format when printing the file timestamp).

It seems like either 1) svn shouldn't be localizing diff output, or 2) svn  
should
have a simple command-line way to override that behavior.

It is somewhat sad that the diff format (or svn's extension of that) cannot  
support
separate per-chunk or per-file metadata.

You (lukasz) are right that rb does search for '(revision ...)', and that's  
probably
the easiest restriction to fix (as long as the parsing code is strict  
enough to
require it be at the end of the path).

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to