Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 970 by tphams: diff viewer is incorrect

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. checkout file and create temporary change
2. post-review <change>
3. visit the url or "View Diff" to see the diff

What is the expected output? What do you see instead?
- The diff shown is wrong. It's showing lines 511-512 deleted in right
file, lines 515-515 added in left file.

What operating system are you using? What browser?
- Fedora8. Firefox 2.

Please provide any additional information below.
- "p4 diff" and post-review generated diff matches
- post-review generated diff (Download diff) is correct
- In "View diff", the patched file is correct. Only the diff shown is wrong.

I can only provide partial diffs from downloading raw diff file bugxxx.patch

--- file
+++ file
@@ -508,11 +508,11 @@ function...
+    echo -e "\nEnclosure Show Topology"
+    echo      "-----------------------"
+    cat $TMP_LOG_ENCL
-      echo -e "\nEnclosure Show Topology"
-      echo      "-----------------------"
-      cat $TMP_LOG_ENCL

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to