Status: NotABug

Comment #4 on issue 970 by chipx86: diff viewer is incorrect

Ah, this is actually correct. It just looks funky due to how the diff is  
(and we use the standard algorithm for this, so it's not Review  
Board-specific really).

As a human, you know that what happened was you moved the "Enclosure Show  
up a bit. However, when the diff algorithm computed the diff, what it saw  
as the
optimal strategy for representing the diff was that the grep line moved. It  
saw the
"Enclosure Show Topology" part as remaining constant. This is due to us  
leading whitespace (so that indentation changes don't create a bunch of  
extra lines
changed when you don't really care too much about them).

I hope that made sense?

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at 

Reply via email to