Comment #1 on issue 999 by sanfordarmstrong: post-review broken for git
when working on a remote SVN branch (not trunk)
http://code.google.com/p/reviewboard/issues/detail?id=999
As I said, I'm not sure if I'm using --parent incorrectly, so here's a
patch that
adds a --gitsvnparent option. It simplifies things for me by disposing
with the
parent diff step (which to me makes no sense in the context of
--parent=some-svn-branch).
So now I can use --gitsvnparent=1.0, and it will simply make a diff against
my local
1.0 branch (which for me represents my SVN 1.0 branch). Everything just
works
because post-review already knows via `git svn info` how to do the svn diff
correctly.
I think a better approach would be to make --parent a little smarter when
dealing
with git-svn branches, but I can't think of a way to tell that some git
branch
represents a clean sync with an SVN branch instead of yet another local
branch that
has an SVN branch in its ancestry. That's why I opted to make a totally
new option
Attachments:
gitsvnparent-option.patch 1.5 KB
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
