Comment #8 on issue 1166 by lonico: view diff failed for files contain Mac newline char (i.e. CR \r) -- use SVN client
http://code.google.com/p/reviewboard/issues/detail?id=1166

Using the following file as an example (all termination characters are CR (or \r)):

Sample file.
Should contain only CR (\r) as
line termination.

(I used scite editor to convert an examine
the line termination.)


$ post-review -d -n default
Processing add of //depot/prod/code-quality/code-review/rbtools/sample.cronly
p4 -G where //depot/prod/code-quality/code-review/rbtools/sample.cronly
diff -urNp /tmp/tmpFhtK-S /u/laurentn/p4/code-review/rbtools/sample.cronly
--- //depot/prod/code-quality/code-review/rbtools/sample.cronly
//depot/prod/code-quality/code-review/rbtools/sample.cronly#1
+++ //depot/prod/code-quality/code-review/rbtools/sample.cronly 2010-03-10 21:39:27
@@ -0,0 +1 @@
the line termination.)o convert an examine
\ No newline at end of file

========================================================================
Note that the issue really comes from the underlying diff utility.
This is with rbtools 0.2RC2 on linux, but the same issue is seen on Windows as well, the whole file is seen as a single line by diff (though I only change scite to SciTE:
C:\Python25\Scripts>..\diff.exe sample.cronly sample2.cronly
1c1
the line termination.)o convert an examine
\ No newline at end of file
---
the line termination.)o convert an examine
\ No newline at end of file

C:\Python25\Scripts>

Attachments:
        sample_cronly.png  5.1 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to