Comment #5 on issue 1359 by zhang.yining: Diff fails for text file with
non-ascii characters
http://code.google.com/p/reviewboard/issues/detail?id=1359
having such issue too, with post-review script.
happens with any diff file contains Chinese character, here's the dump with
--debug
turned on:
repository info: Path: https://svn.mysite.com/repos/myproject, Base
path:
/website/trunk, Supports changesets: False
svn diff --diff-cmd=diff app/src/index.php
svn info app/src/index.php
svn info app/src/index.php
svn info app/src/index.php
svn info app/src/index.php
Looking for 'www.mysite.com /reviewboard/' cookie in
/home/yining/.post-review-
cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
repository info: Path: file:///opt/svn/repos/myproject/website/trunk,
Base path:
/, Supports changesets: False
Attempting to create review request on
file:///opt/svn/repos/myproject/website/trunk for None
HTTP POSTing to
http://www.mysite.com/reviewboard/api/json/reviewrequests/new/:
{'repository_path': u'file:///opt/svn/repos/myproject/website/trunk'}
Review request created
Uploading diff, size: 277
HTTP POSTing to
http://www.mysite.com/reviewboard/api/json/reviewrequests/27/diff/new/:
{'basedir':
'/'}
Traceback (most recent call last):
File "/opt/python/2.6.4/bin/post-review", line 8, in <module>
load_entry_point('RBTools==0.2rc1', 'console_scripts', 'post-review')()
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 2774, in main
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 2480, in tempt_fate
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 503, in upload_diff
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 622, in api_post
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 597, in http_post
File "/opt/python/2.6.4/lib/python2.6/site-packages/RBTools-0.2rc1-
py2.6.egg/rbtools/postreview.py", line 656, in _encode_multipart_formdata
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 436:
ordinal not
in range(128)
Python version: 2.6.4
ReviewBoard version: 1.0.5.1
RBTools version: 0.2rc1-py2.6
post-review version: 0.8
It's a show stopper for me if this issue can not be fixed.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
