Status: New Owner: ---- Labels: Type-Enhancement Priority-Medium
New issue 1603 by daveismith: Encoded URLs are not handled correctly http://code.google.com/p/reviewboard/issues/detail?id=1603 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0.6 What's the URL of the page this enhancement relates to, if any? https://<omitted>/review/r/24/diff/#index_header Describe the enhancement and the motivation for it. My Repository names have spaces in them, and when I encode the space as a %20 in the URL, ReviewBoard returns the following exception Could not open the requested SVN filesystem Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/views.py", line 153, in view_diff interdiffset, highlighting, True) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 623, in get_diff_files large_data=True) File "/usr/lib/python2.5/site-packages/Djblets-0.5.8- py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 622, in <lambda> enable_syntax_highlighting), File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 344, in get_chunks old = get_original_file(filediff) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 251, in get_original_file large_data=True)[0] File "/usr/lib/python2.5/site-packages/Djblets-0.5.8- py2.5.egg/djblets/util/misc.py", line 162, in cache_memoize data = lookup_callable() File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 250, in <lambda> data = cache_memoize(key, lambda: [fetch_file(file, revision)], File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/diffviewer/diffutils.py", line 229, in fetch_file data = tool.get_file(file, revision) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0.6- py2.5.egg/reviewboard/scmtools/svn.py", line 118, in get_file raise SCMError(e) SCMError: Could not open the requested SVN filesystem What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
