Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1668 by AaronJSherman: Diffs not applying cleanly circa 1.0.7 with odd line endings

*NOTE: Do not post confidential information in this bug report.*

What version are you running? 1.0.7

What's the URL of the page containing the problem? N/A

What steps will reproduce the problem?
1. Create a file with mixed DOS and Unix line endings
2. post-review
3. view diffs

What is the expected output? What do you see instead?

The diff page produces an error such as "Error: The patch to '...' didn't
apply cleanly."

What operating system are you using? What browser?

Linux. Any browser.

Please provide any additional information below.

In one case, I found that a user had a file containing line endings that
were solely carriage returns. In one I found the file contained mixed CR/LF
and LF. While I realize that this is not ideal, at least providing the user
with some feedback on what went wrong would help them solve their own
problems (e.g. changing the line endings or marking the file as binary).

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to