Comment #7 on issue 1668 by chipx86: Diffs not applying cleanly circa 1.0.7
with odd line endings
Nevermind, I have a test case now. I just don't have a fix that's working.
The problem is that we do newline normalization so that files with lines
\r, \n, \r\n, or \r\r\n are processed correctly, but this completely breaks
If you have:
And then you add a couple lines, diff will give you:
See how diff considers the ^M to be part of the string, not a newline.
However, our parser will see that ^M and try to make it a newline, in order
around other file formats and oddities. This then breaks us, since we'll
normalized diff that looks like:
We may have to process diffs separately, but it's going to be hard to do so
causing new problems.
I'd be really interested in finding out how these files are getting so
You received this message because you are subscribed to the Google Groups
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
For more options, visit this group at