Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1715 by Rb breaks Git patches with new files/deleted files

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.5 beta 2 (dev)

What steps will reproduce the problem?
1. Create a new review request using a patch from a Git repository, which creates a new file. The header of the hunk looks like this:

    diff --git a/ b/
    new file mode 100644
    index 0000000..e4da686
    --- /dev/null
    +++ b/
    @@ -0,0 +1 @@
    +Some content

2. Then, download the patch from ReviewBoard, by clicking on the "Download Diff" button. the patch contains the following content:

    diff --git a/ b/
    --- /dev/null
    +++ b/
    @@ -0,0 +1 @@
    +Some content

3. Using "git apply" to apply the patch, retrieved from the Reviewboard, on a repository result in the following error:

    $ git apply foo.patch
    error: dev/null: No such file or directory

4. If I manually update the patch file downloaded from the ReviewBoard, adding the two lines which has disappeared, the patch can be applied by git

AFAIR, the same problem occurs when the patch contains files which have been deleted.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to