Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1873 by sigurdga: Post-commit review does not work with code committed to git repository (master branch)
http://code.google.com/p/reviewboard/issues/detail?id=1873

What version are you running?
1.5

What's the URL of the page containing the problem?
http://localhost/reviews/r/10/diff/#index_header

What steps will reproduce the problem?
1. Setup a git repository within the admin tool
2. Commit changes to your git repository
3. Use post-review to send a (post-commit) review request for changes already committed, using --revision-range=hash:hash
4. Look at the diff in reviewboard

What is the expected output? What do you see instead?
Expected was a nice diff of my commits for the range specified. What I get is:

The patch to 'filename.py' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.4yHsSV' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.4yHsSV/tmp6zizmb Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.4yHsSV/tmp6zizmb-new.rej

Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/views.py", line 153, in view_diff
    interdiffset, highlighting, True)
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/diffutils.py", line 1063, in get_diff_files
    large_data=True)
File "/usr/local/lib/python2.6/dist-packages/djblets/util/misc.py", line 166, in cache_memoize
    data = lookup_callable()
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/diffutils.py", line 1062, in <lambda>
    enable_syntax_highlighting)),
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/diffutils.py", line 549, in get_chunks
    new = get_patched_file(old, filediff)
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/diffutils.py", line 374, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
File "/usr/local/lib/python2.6/dist-packages/reviewboard/diffviewer/diffutils.py", line 242, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'filename.py' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.4yHsSV' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.4yHsSV/tmp6zizmb
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file /tmp/reviewboard.4yHsSV/tmp6zizmb-new.rej


What operating system are you using? What browser?
Ubuntu 10.10, Chromium 6.0.472.63 (59945).


Please provide any additional information below.

It looks like patch is confused as the code to review is already commited, and it asks to reverse the change introduced by the patch.

I guess reviewboard does not work with code already in repository. At least for the master branch with git.

I am not sure if this is a defect or a documentation issue. I do not think it is clear from the documentation that this is not a supported use case. I would really hope that it would be supported to do it our way, as quite a few organizations want all code to be committed as early as possible to the central repository.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to