Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium
New issue 1953 by fedotov.aleksei: Addressing comments on "View Diff" page
is not usable
http://code.google.com/p/reviewboard/issues/detail?id=1953
What version are you running?
1.5
Describe the enhancement and the motivation for it.
When particular user gets the review feedback and watch someone comments he
sees that comments are relate to the one or more lines of code. Sometimes
an idea to switch to “View Diff” mode and see surrounding code appears.
Then user does it. In the “View Diff” mode user clicks on the commented
line to get the window with comments appeared. Near that window appears
another window (titled "Your comment") where the code owner can type his
comments.
At this point I assume that comments in the green box are the answer
comments. But when I click to “Publish changes” button I see that this is
not that. The comments does not appeared as answers but as new comments at
the end of the "View Review" page.
So, particular user has to keep both “View Diff” and “View Review” windows
opened (or clicking back and forth again and again) to be able to watch
surrounding code and explain his thoughts about reviewer comments. I think
it is not convenient…
Please provide any additional information below.
I suggest put something like a combo box filled with the names of
commentators and timestamps at the bottom of the "Your comment" window. So
the user would type in his comment in that window, choose one of the
comments from the combo box he wants his input to be a reply to, and then
click save button. Also something like general value can be added as item
of that combo box to have the default behavior like it does now.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
