Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2077 by a.chuk...@gmail.com: Incorrect git diff parsing
http://code.google.com/p/reviewboard/issues/detail?id=2077

* NOTE: Do not post confidential information in this bug report. *
*       If you need immediate support, please contact            *
*       reviewbo...@googlegroups.com                             *

What version are you running?
Review board 1.5.5


What steps will reproduce the problem?
1. Make changes to an existing file.
2. Use post-review to upload it.
3. It fails complaining on non-existent revision.

What is the expected output? What do you see instead?
Seems that it treats git file's SHA1 to be commit id.

Please provide any additional information below.

git diff --full-index --cc -r HEAD^..HEAD
diff --git a/tmp b/tmp
index 44957fa4b300b0fbee878cb7aa95c495371f4a5c..5a3f4060c35281b591f0d09f0b10815aac6e5b20 100644
--- a/tmp
+++ b/tmp
@@ -1,2 +1 @@
-artasrt
 Now add small changes
diff --git a/tmp2 b/tmp2
new file mode 100644
index 0000000000000000000000000000000000000000..1c975dce2df0cbcd48b1fb67f53abef77919945a
--- /dev/null
+++ b/tmp2
@@ -0,0 +1 @@
+tarstasrt

post-review -d -r 31 --revision-range=HEAD^:HEAD

Got API Error 207 (HTTP code 200): The file was not found in the repository Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail', u'file': u'tmp', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'44957fa4b300b0fbee878cb7aa95c495371f4a5c'}


(It thinks that SHA1 of old tmp is a revision ID)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to