Comment #3 on issue 2077 by chris.a....@gmail.com: Incorrect git diff parsing
http://code.google.com/p/reviewboard/issues/detail?id=2077

I'm running into what appears to be the same issue here. I have a project attached to github, and it's failing to parse the diffs. It complains about revisions not existing:
Got API Error 207 (HTTP code 400): The file was not found in the repository Error data: {u'stat': u'fail', u'file': u'plugins/com.aptana.editor.dtd/parsing/DTD.grammar', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u'14f130fca4dfd182e42e5b99ad543c39ba8517e3'}

The diff itself is using the SHAs of the blobs representing the file contents before and after:

diff --git a/plugins/com.aptana.editor.dtd/parsing/DTD.grammar b/plugins/com.aptana.editor.dtd/parsing/DTD.grammar index d5f60c4b1b447b0fb6191c1a34a4a40f248a7905..14f130fca4dfd182e42e5b99ad543c39ba8517e3 100644

Github expects the commit SHA containing that version of the file in it's URLs, like so:
https://github.com/aptana/studio3/blob/5a8245f18a6a844c99eca27b497a134cd67ce431/plugins/com.aptana.editor.dtd/parsing/DTD.grammar

This also seems to be the same issue?
http://www.mail-archive.com/reviewboard@googlegroups.com/msg06300.html

Is there a way I can fix this manually? if I change the repository from "Github" to custom, it shows http://github.com/api/v2/yaml/blob/show/aptana/studio3/<revision> as the raw file URL mask, and substituting the blob from the diff there does return what I'd expect (though note that it becomes https):
https://github.com/api/v2/yaml/blob/show/aptana/studio3/14f130fca4dfd182e42e5b99ad543c39ba8517e3

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to