Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2176 by ben.al...@gmail.com: Diff parsing fails if extra tabs are
detected
http://code.google.com/p/reviewboard/issues/detail?id=2176
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* reviewbo...@googlegroups.com *
What version are you running?
1.6beta2
What's the URL of the page containing the problem?
Any review request page
What steps will reproduce the problem?
1. Publish a review request using a known-good diff
2. Download the diff, and modify the header information for one of the
chunks to use two tabs between the file name and revision number (example
below)
3. Attempt to upload the updated diff
What is the expected output? What do you see instead?
I get an "unable to parse diff" error message (screenshot attached)
What operating system are you using? What browser?
Client is running Windows 7 (64-bit), Firefox 5.0 (also seen on IE8 and
IE9). The RB server is running Ubuntu 10.10.
Please provide any additional information below.
The lines that you need to modify are those that look like this:
--- version.mk (revision 2333)
+++ version.mk (working copy)
To reproduce this error, there needs to be two tabs between the filename
and the opening parenthesis that follows it. By default, the CLI
Subversion tools produce diffs with only one tab. However, some other
tools insert extra tabs here and the diffs require manual editing before RB
will accept them.
I tested both the one-tab and two-tab versions with the CLI 'patch' utility
and both were able to be applied with no problems.
Attachments:
RB_error_message.png 14.4 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
