Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2236 by shols...@gmail.com: RBTools SVN client doesn't handle directory renames correctly.
http://code.google.com/p/reviewboard/issues/detail?id=2236

What version are you running?
RBTools 0.3.2

Description of the problem?
The post-review svn client doesn't handle directory renames correctly. The problem occurs when uploading the diff. Index, +++ and --- lines contain new paths (that don't exist) and cause ReviewBoard to fail when verifying the base path.


What steps will reproduce the problem?
1. Checkout SVN repository.
2. Rename a revisioned directory.
3. Modify a file within the renamed revisioned directory.
4. Verify `svn status` shows 'M+' next to modded file.
5. Use post-review to attempt to create a RB ticket.
6. Observe explosions.

What is the expected output? What do you see instead?
One expects to see a URL to a RB ticket. You see a "Error uploading diff." instead.


Please provide any additional information below.
This method https://github.com/reviewboard/rbtools/blob/master/rbtools/clients/svn.py#L167 doesn't fix the issue because the files within the renamed directory aren't scheduled to be renamed (they have a normal schedule).

Fix?
I've started work on a fork here: https://github.com/sholsapp/rbtools/blob/master/rbtools/clients/svn.py#L169

I've hand tested it and it correctly resolves the issue, but has the limitation that the OLD path name is displayed in ReviewBoard. I still need to write unit tests.



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to