Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2236 by RBTools SVN client doesn't handle directory renames correctly.

What version are you running?
RBTools 0.3.2

Description of the problem?
The post-review svn client doesn't handle directory renames correctly. The problem occurs when uploading the diff. Index, +++ and --- lines contain new paths (that don't exist) and cause ReviewBoard to fail when verifying the base path.

What steps will reproduce the problem?
1. Checkout SVN repository.
2. Rename a revisioned directory.
3. Modify a file within the renamed revisioned directory.
4. Verify `svn status` shows 'M+' next to modded file.
5. Use post-review to attempt to create a RB ticket.
6. Observe explosions.

What is the expected output? What do you see instead?
One expects to see a URL to a RB ticket. You see a "Error uploading diff." instead.

Please provide any additional information below.
This method doesn't fix the issue because the files within the renamed directory aren't scheduled to be renamed (they have a normal schedule).

I've started work on a fork here:

I've hand tested it and it correctly resolves the issue, but has the limitation that the OLD path name is displayed in ReviewBoard. I still need to write unit tests.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to