Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2256 by seamus.l...@gmail.com: post-review should use -c option
when calling svn diff with single rev
http://code.google.com/p/reviewboard/issues/detail?id=2256
What version are you running?
1.6 RC2
What's the URL of the page containing the problem?
post-review
What steps will reproduce the problem?
1.Point post-review to SVN repo
2.Run post-review with single --revision-range option, e.g.
post-review --revision-range=157778 --debug
What is the expected output? What do you see instead?
Expected debug output:
----------------------
RBTools 0.3.3
Home = /home/<snip>
svn info
diff --version
repository info: Path: http://<snip>/repo, Base path: /<snip>/trunk,
Supports changesets: False
HTTP GETting api/
HTTP GETting http://<snip>/reviews/api/info/
Using the new web API
svn diff --diff-cmd=diff -c 157778
^CTraceback (most recent call last):
<snip>
KeyboardInterrupt
Actual debug output:
--------------------
RBTools 0.3.3
Home = /home/<snip>
svn info
diff --version
repository info: Path: http://<snip>/repo, Base path: /<snip>/trunk,
Supports changesets: False
HTTP GETting api/
HTTP GETting http://<snip>/reviews/api/info/
Using the new web API
svn diff --diff-cmd=diff -r 157778
^CTraceback (most recent call last):
<snip>
KeyboardInterrupt
What operating system are you using? What browser?
Ubuntu 9.10
Please provide any additional information below.
The documentation states "If you only need to post a single revision, you
can type:
$ post-review --revision-range=REVISION"
However, it uses the -r option with svn diff, which is equivalent to
0:157778, and begins fetching EVERY change made on the current path, up to
rev 157778 in
this example. It should use the -c option with svn diff.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
