Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2369 by [email protected]: post-review handling of added
files in a Perforce changelist is wrong
http://code.google.com/p/reviewboard/issues/detail?id=2369
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* [email protected] *
What version are you running?
RBTools 0.3.3
What's the URL of the page containing the problem?
-
What steps will reproduce the problem?
1.post-review an old submitted change in a Perforce repo
2.
3.
What is the expected output? What do you see instead?
If the change has an added file, post-review will use its last revision for
the diff, not the initial #1 revision. This file has a lot of improvements
since the addition of it (=reviewed change).
What operating system are you using? What browser?
WinXP
Please provide any additional information below.
I noticed that the code snippet:
elif changetype in ['add', 'branch', 'move/add']:
# We have a new file, get p4 to put this new file into a
pretty
# temp file for us. No old file to worry about here.
if cl_is_pending:
new_file = self._depot_to_local(depot_path)
else:
self._write_file(depot_path, tmp_diff_to_filename)
new_file = tmp_diff_to_filename
changetype_short = "A"
should be changed to (the depot path should be decorated with a #1):
elif changetype in ['add', 'branch', 'move/add']:
# We have a new file, get p4 to put this new file into a
pretty
# temp file for us. No old file to worry about here.
if cl_is_pending:
new_file = self._depot_to_local(depot_path)
else:
new_depot_path = "%s#%s" %(depot_path, 1)
self._write_file(new_depot_path, tmp_diff_to_filename)
new_file = tmp_diff_to_filename
changetype_short = "A"
after the change the handling of additions work fine.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
