Comment #2 on issue 2359 by elguerom...@gmail.com: Review creation fails with patches created with Subversion 1.7.x if they include a property change.
http://code.google.com/p/reviewboard/issues/detail?id=2359

Here is a sample header extracted from a diff that has property changes and fails when being uploaded to ReviewBoard. Hopefully this helps someone to track this down.

I wonder if pysvn needs to be updated to use svn 1.7.x since ReviewBoard uses that to parse the diff file. The devs for pysvn seem to be working on an update for svn 1.7.x.

Index: library/ACS/Filter/Date
===================================================================
--- library/ACS/Filter/Date     (revision 2210)
+++ library/ACS/Filter/Date     (revision 2214)

Property changes on: library/ACS/Filter/Date
___________________________________________________________________
Added: bugtraq:label
## -0,0 +1 ##
+Issue #
Added: bugtraq:message
## -0,0 +1 ##
+issue %BUGID%
Added: bugtraq:warnifnoissue
## -0,0 +1 ##
+true
Added: bugtraq:url
## -0,0 +1 ##
+http://xxxxxx.com/mantis/view.php?id=%BUGID%
Index: library/ACS/Pdf/Order.php
===================================================================
--- library/ACS/Pdf/Order.php   (revision 2210)
+++ library/ACS/Pdf/Order.php   (revision 2214)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to