Comment #7 on issue 1533 by [email protected]: File Names Cut off in
Diff Viewer
http://code.google.com/p/reviewboard/issues/detail?id=1533
Just a hint on where you can look at:
Check the "def parse_special_header(self, linenum, info)" in
reviewboard/diffviewer/parser.py
Assume that you have the following in diff file:
Index: /Directory One/Dir Two/File.txt
I'm not sure why it does the following:
info['index'] = self.lines[linenum].split(None, 2)[1]
'/Directory'
When in fact I'd expect it to behave like this:
info['index'] = self.lines[linenum].split(None, 1)[1]
'/Directory One/Dir Two/File.txt'
Then in svn.py the value of info['index'] is used as file name for binary
files.
Similar split is in git.py but I'm not familiar with their diff format at
all.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
