Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2792 by [email protected]: Error Uploading svn diff file with
property changes or binary files
http://code.google.com/p/reviewboard/issues/detail?id=2792
* NOTE: For customer support, please post to *
* [email protected] *
* *
* Do not post confidential information in this bug report. *
* If you need immediate support, please contact *
* [email protected] *
What version are you running?
RB 1.6.13
RBTools 0.4.2
What's the URL of the page containing the problem?
na
What steps will reproduce the problem?
1. create svn repository
2. add to folders in repo root f1 and f2
3. add file with text to f1 and commit
4. checkout f2 and merge changes from f1 into the working copy
5. use "svn diff --show-copies-as-adds . > f2.diff" to create diff file
6. call post-review to create review request ("post-review
--server=http://path/to/server/ -d --diff-filename=f2.diff -p
What is the expected output? What do you see instead?
Expected: Create new Review Request and add diff file
What happens: post-review reports an error uploading the diff (API Error
105).
Post Review Error:
============================
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {u'fields': {u'path':
[u"URL 'http://path/to/server/svn/sandbox/review' refers to a
directory\nCan't get text contents of a directory"]}, u'st
at': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
============================
Diff file: see attachment
What operating system are you using? What browser?
Win7 / Win Server 2k3
Firefox 16
Please provide any additional information below.
If you add a step 4a. and remove the svn:merge property it will work.
If you add a binary file to f1 in Step 3 it wont work, even if the
svn:merge property is removed.
As far as I understood Issue 2359
(http://code.google.com/p/reviewboard/issues/detail?id=2359) and Issues
2561 (http://code.google.com/p/reviewboard/issues/detail?id=2561, merged
into 2359), this should work.
Or did I do something wrong?
Thanks in advance,
Karl
Attachments:
f2.diff 1.1 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
